WIP(SharingService): Provide node information for remote shares #45613
Conversation
Signed-off-by: fenn-cs <fenn25.fn@gmail.com> [skip-ci]
Fenn-CS
force-pushed
the
fix-44318-remote-share-not-listed
branch
from
95f8f6e
to
6cdfa20
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -812,6 +812,15 @@ | |||
| if ((int)$share['share_type'] === IShare::TYPE_GROUP && (int)$share['parent'] > 0) { | |||
| $toRemove[] = $share['parent']; | |||
| } | |||
|
|
|||
| // Create share object and attempt to get and sent node data? | |||
| $shareObject = new Share($this->rootFolder, $this->userManager); | |||
Check failure
Code scanning / Psalm
TooManyArguments Error
|
|
||
| // Create share object and attempt to get and sent node data? | ||
| $shareObject = new Share($this->rootFolder, $this->userManager); | ||
| $shareObject->setId((int)$share['id']) |
Check failure
Code scanning / Psalm
UndefinedMethod Error
| @@ -812,6 +812,15 @@ | |||
| if ((int)$share['share_type'] === IShare::TYPE_GROUP && (int)$share['parent'] > 0) { | |||
| $toRemove[] = $share['parent']; | |||
| } | |||
|
|
|||
| // Create share object and attempt to get and sent node data? | |||
| $shareObject = new Share($this->rootFolder, $this->userManager); | |||
Check notice
Code scanning / Psalm
DeprecatedClass Note
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Resolves : #44318