Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files_sharing): fix parsing of remote shares #45698

Merged
merged 6 commits into from
Jun 12, 2024
Merged

fix(files_sharing): fix parsing of remote shares #45698

merged 6 commits into from
Jun 12, 2024

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jun 6, 2024 •
edited
Loading

Fix #44318

  • Also fix various missing data for external shares
  • And also fix avatar for remote shares (+ dark avatar support)

Pending shares

Before After
2024-06-06_19-41_1 2024-06-06_19-41_2

Files list

Before After
2024-06-06_19-41 2024-06-06_19-42

@skjnldsv skjnldsv added this to the Nextcloud 30 milestone Jun 6, 2024
@skjnldsv skjnldsv self-assigned this Jun 6, 2024
@skjnldsv skjnldsv mentioned this pull request Jun 6, 2024
Closed
@skjnldsv skjnldsv changed the title fix(files_sgaring): fix parsing of remote shares fix(files_shring): fix parsing of remote shares Jun 6, 2024
@skjnldsv skjnldsv requested review from a team, Fenn-CS, szaimen, sorbaugh, ArtificialOwl, artonge and Pytal and removed request for a team June 6, 2024 17:39
@skjnldsv skjnldsv requested review from come-nc and removed request for sorbaugh June 6, 2024 17:43
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 6, 2024
View reviewed changes
core/Controller/AvatarController.php Fixed Show resolved Hide resolved
core/Controller/AvatarController.php Fixed Show fixed Hide fixed
@AndyScherzinger AndyScherzinger changed the title fix(files_shring): fix parsing of remote shares fix(files_sharing): fix parsing of remote shares Jun 6, 2024
@szaimen szaimen removed their request for review June 6, 2024 20:01
@provokateurin provokateurin self-requested a review as a code owner June 7, 2024 10:09
come-nc
come-nc reviewed Jun 10, 2024
View reviewed changes
apps/dav/lib/Connector/Sabre/SharesPlugin.php Show resolved Hide resolved
apps/dav/lib/Connector/Sabre/SharesPlugin.php Show resolved Hide resolved
apps/dav/lib/Server.php Outdated Show resolved Hide resolved
@skjnldsv
fix(files_sharing): fix parsing of remote shares
a0a3656 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv
fix(core): allow guest avatar fallback
fb11672 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
skjnldsv and others added 4 commits June 12, 2024 10:27
@skjnldsv
fix(dav): also return shared-with-me shares data
4a77fe3 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv
fix(files_sharing): dark avatar support
8bed232 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@provokateurin @skjnldsv
fix(core): Return X-NC-IsCustomAvatar for guest avatars too
c8e7678 
Signed-off-by: provokateurin <kate@provokateurin.de>
@skjnldsv
chore: compile assets
00803f5 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv skjnldsv requested a review from come-nc June 12, 2024 08:28
@skjnldsv skjnldsv merged commit 4c32ab7 into master Jun 12, 2024
164 checks passed
@skjnldsv skjnldsv deleted the fix/files-remote-shares branch June 12, 2024 11:02
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Jun 12, 2024
@skjnldsv
Copy link
Member Author

/backport to stable29

@skjnldsv
Copy link
Member Author

/backport to stable28

@backportbot backportbot bot mentioned this pull request Jun 12, 2024
Merged
2 tasks
@backportbot backportbot bot mentioned this pull request Jun 12, 2024
Merged
2 tasks
@SystemKeeper SystemKeeper mentioned this pull request Jun 12, 2024
Closed
@nickvergessen nickvergessen mentioned this pull request Jun 13, 2024
Merged
3 tasks
@juliushaertl
Copy link
Member

This seems to have added running some more heavy queries twice, filed at #46546

@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@artonge artonge artonge approved these changes

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS Fenn-CS was automatically assigned from nextcloud/server-frontend

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@Pytal Pytal Awaiting requested review from Pytal

@provokateurin provokateurin Awaiting requested review from provokateurin provokateurin is a code owner

@come-nc come-nc Awaiting requested review from come-nc

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: files feature: sharing
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.

[Bug]: Remote shares are not listed in share views
6 participants
@skjnldsv @juliushaertl @AndyScherzinger @artonge @come-nc @provokateurin