feat(theming): Provide CSS variable for favorite color and adjust for dark mode #44034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
changed the title
susnux
force-pushed
the
fix/favorite-color
branch
from
9fc9e04 to
79409ea
Compare
skjnldsv
approved these changes
Mar 6, 2024
4 tasks
This comment was marked as resolved.
This comment was marked as resolved.
skjnldsv
added
2. developing
susnux
force-pushed
the
fix/favorite-color
branch
from
79409ea to
ce4b16c
Compare
susnux
added
3. to review
This comment was marked as resolved.
This comment was marked as resolved.
skjnldsv
added
2. developing
susnux
force-pushed
the
fix/favorite-color
branch
from
ce4b16c to
2c3d35a
Compare
… dark mode Co-authored-by: Simon L <szaimen@e.mail.de> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/favorite-color
branch
from
2c3d35a to
f3a74c5
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Provide the favorite color as a CSS variable and adjust it for the dark mode to look a bit nicer (bright mode does not work due to contrast issues).
Checklist