Skip to content

feat(settings): Make the AppScore component to use SVG icons #44028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 6, 2024
Merged

feat(settings): Make the AppScore component to use SVG icons #44028

merged 2 commits into from
Mar 6, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Mar 6, 2024 •
edited
Loading

Summary

Use SVG icons instead of images for the app score component.

Screen Shot 2024-03-06 at 12 39 47
Screenshot 2024-03-06 at 12-38-06 Settings - Apps - Nextcloud

Checklist

@susnux susnux added this to the Nextcloud 29 milestone Mar 6, 2024
@susnux susnux force-pushed the feat/app-score-use-svg branch from d62d7cc to 150d428 Compare March 6, 2024 11:33
szaimen
szaimen approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine but didnt test

@susnux susnux force-pushed the feat/app-score-use-svg branch from 150d428 to 61b1f4e Compare March 6, 2024 11:42
@susnux susnux changed the title feat(settings): Make the AppScorce component to use SVG icons feat(settings): Make the AppScore component to use SVG icons Mar 6, 2024
szaimen
szaimen reviewed Mar 6, 2024
View reviewed changes
@susnux susnux force-pushed the feat/app-score-use-svg branch from 61b1f4e to 25a3715 Compare March 6, 2024 14:15
Pytal
Pytal reviewed Mar 6, 2024
View reviewed changes
@susnux susnux force-pushed the feat/app-score-use-svg branch from 25a3715 to e2091f8 Compare March 6, 2024 17:40
susnux added 2 commits March 6, 2024 21:12
@susnux @skjnldsv
feat: Make the AppScorce component to use SVG icons
7077bdf 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux @skjnldsv
chore: Compile assets
2308283 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@skjnldsv skjnldsv force-pushed the feat/app-score-use-svg branch from e2091f8 to 2308283 Compare March 6, 2024 20:16
@skjnldsv skjnldsv merged commit 8fded1d into master Mar 6, 2024
@skjnldsv skjnldsv deleted the feat/app-score-use-svg branch March 6, 2024 20:16
@blizzz blizzz mentioned this pull request Mar 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@szaimen szaimen szaimen approved these changes

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement feature: apps management
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
4 participants
@susnux @Pytal @szaimen @skjnldsv