Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove comments tab from files #41201

Closed
wants to merge 2 commits into from
Closed

remove comments tab from files #41201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b64532
remove comments tab from files
sorbaugh Oct 30, 2023
224e8eb
Make ICommentsManager::load() function no-op and deprecate it
sorbaugh Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 0 additions & 73 deletions apps/comments/src/activitytabviewplugin.js
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the use of this file?

This file was deleted.

6 changes: 0 additions & 6 deletions apps/comments/src/comments-app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,7 @@
*
*/

import CommentsInstance from './services/CommentsInstance.js'
nickvergessen marked this conversation as resolved.
Show resolved Hide resolved

// Init Comments
if (window.OCA && !window.OCA.Comments) {
Object.assign(window.OCA, { Comments: {} })
}

// Init Comments App view
Object.assign(window.OCA.Comments, { View: CommentsInstance })
console.debug('OCA.Comments.View initialized')
61 changes: 0 additions & 61 deletions apps/comments/src/comments-tab.js
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion apps/comments/src/comments.js
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file still needed?

Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,5 @@

import './app.js'
import './templates.js'
import './activitytabviewplugin.js'

window.OCA.Comments = OCA.Comments
Loading
Loading