Skip to content

Conversation

sorbaugh
Copy link
Contributor

Summary

This is the the second part of a two part Pull Request to move code from the comments app found in server to the activity app.

Here is the other PR: nextcloud/activity#1387

Checklist

@nickvergessen nickvergessen added the pending documentation This pull request needs an associated documentation update label Oct 31, 2023
@nickvergessen
Copy link
Member

Setting pending documentation This pull request needs an associated documentation update because it's needed in case the feature is being deprecated or removed directly.

@sorbaugh
Copy link
Contributor Author

Thanks for pointing it out! For context, the comments feature is being moved to the activity repo, so this is one of two pull requests.
nextcloud/activity#1387

@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
@nickvergessen nickvergessen force-pushed the feature/sorbaugh/combine-comments-activity branch from eebbf87 to 224e8eb Compare November 2, 2023 10:17
@nickvergessen nickvergessen self-requested a review November 2, 2023 10:20
@nickvergessen nickvergessen dismissed their stale review November 2, 2023 10:20

Dismissing my review

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file still needed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the use of this file?

Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, most of this need to be kept as:

if activity app is disabled and comments app enabled:
show comments tab as-is

@nickvergessen
Copy link
Member

That also means we can keep the public API working for apps using the comments UI, that's great news!

This was referenced Nov 6, 2023
@blizzz blizzz mentioned this pull request Nov 14, 2023
@susnux
Copy link
Contributor

susnux commented Nov 15, 2023

closing in favor of #41491
(for reuse code and not duplicate comments code to activity app)

@susnux susnux closed this Nov 15, 2023
@susnux susnux deleted the feature/sorbaugh/combine-comments-activity branch November 15, 2023 13:25
@skjnldsv skjnldsv removed the pending documentation This pull request needs an associated documentation update label Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants