Conversation
f270e6f to
936a04e
Compare
|
I should have put this in draft first, sorry about that folks but this is not ready for review as the implementation need to be tested with at least one modal for correctness and in this case that is #36989. (See todo in PR description) |
db6ead6 to
89c1887
Compare
|
I believe this is functionally identical to https://github.com/focus-trap/focus-trap? If so then we can use the lib instead i.e. #37780 |
|
Thanks @Pytal! Did not know of this. Even though it was tricky to write this, that looks solid!
|
89c1887 to
6a953fa
Compare
| context.$file.removeClass('mouseOver'); | ||
| $trigger.removeClass('open'); | ||
| $trigger.attr('aria-expanded', 'false'); | ||
| menuFocusTrap.deactivate() |
There was a problem hiding this comment.
Resolves : #36989 Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
6a953fa to
eef9bcc
Compare
|
Kinda the same, files to vue already fixes it 🙈 |
Resolves : #36989
Before
before.webm
After
after.webm