Conversation
Pytal
force-pushed
the
enh/a11y-focus-dialog
branch
from
9a1e917 to
1d6f379
Compare
Pytal
added
3. to review
skjnldsv
approved these changes
Apr 21, 2023
artonge
approved these changes
Apr 24, 2023
Contributor
|
@hamza221 is nextcloud/photos#1711 still needed with this PR? |
Contributor
it's not :)) , This is a cleaner and better approach |
Contributor
|
/backport to stable26 |
Pytal
added
4. to release
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
force-pushed
the
enh/a11y-focus-dialog
branch
from
1d6f379 to
79310bd
Compare
1 task
Member
|
/backport to stable25 |
1 task
This was referenced Jun 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Focus is now trapped within dialogs
Checklist