Limit missing primary key fail to new tables and comment out for now #31580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
bug
3. to review
nickvergessen
requested review from
a team,
ArtificialOwl,
CarlSchwan,
ChristophWurst and
PVince81
and removed request for
a team
ChristophWurst
approved these changes
Mar 15, 2022
nickvergessen
changed the title
|
Reasons to disable for now:
|
|
cc @PVince81 lets disable for now |
PVince81
reviewed
Mar 16, 2022
This will work on CI so devs notice it when they install the app for testing, and at the same time existing faulty tables don't break the upgrade to 24 Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
nickvergessen-patch-2
branch
from
7f01ad7 to
3bed983
Compare
|
Rebased as the PR was broken after Carl rebased when github had issues last week |
|
@nickvergessen This broke the CI, the nodb drone step won’t pass: |
nickvergessen
added a commit
that referenced
this pull request
Mar 22, 2022
see #31580 (comment) for details Signed-off-by: Joas Schilling <coding@schilljs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will work on CI so devs notice it when they install the app for testing,
and at the same time existing faulty tables don't break the upgrade to 24
Regression from #31513