Skip to content

Enforce primary keys as they are required to be performant in MySQL c… #31513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 15, 2022
Merged

Enforce primary keys as they are required to be performant in MySQL c… #31513

merged 2 commits into from
Mar 15, 2022

Conversation

@nickvergessen
Copy link
Member

…lusters

We are pretty close already to 24, so I'm also fine with delaying this until 25

@nickvergessen
Enforce primary keys as they are required to be performant in MySQL c…
b35253a 
…lusters

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 24 milestone Mar 10, 2022
@nickvergessen nickvergessen requested review from a team, ArtificialOwl, icewind1991 and skjnldsv and removed request for a team March 10, 2022 09:26
@nickvergessen nickvergessen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Mar 10, 2022
@nickvergessen
Copy link
Member Author

Test needs adjusting

@nickvergessen
Add a test for primary keys
1970d3d 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 10, 2022
PVince81
PVince81 approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

we're not in feature freeze yet and after feature freeze we also freeze the APIs, so that's when app developers still have time to stabilize their apps while we go into beta

in the worst case if too many complains we can always revert before final

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 15, 2022
@nickvergessen nickvergessen merged commit 04a4562 into master Mar 15, 2022
@nickvergessen nickvergessen deleted the techdebt/noid/enforce-primary-keys branch March 15, 2022 09:53
@CarlSchwan CarlSchwan mentioned this pull request Mar 15, 2022
Merged
@nickvergessen nickvergessen mentioned this pull request Mar 15, 2022
Merged
This was referenced Mar 15, 2022
Closed
Closed
@nickvergessen nickvergessen mentioned this pull request Mar 16, 2022
Closed
@tobiasKaminsky tobiasKaminsky mentioned this pull request Mar 16, 2022
Closed
@tcitworld tcitworld mentioned this pull request Mar 18, 2022
Closed
5 tasks
@nickvergessen nickvergessen mentioned this pull request Apr 4, 2022
Merged
@nickvergessen nickvergessen mentioned this pull request Apr 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81 PVince81 PVince81 approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish feature: install and update technical debt

Projects

None yet

Milestone

Nextcloud 24

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen @PVince81 @CarlSchwan