Validate overwrite.cli.url to be a url in setup check
#31430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
force-pushed
the
enh/31429/improve-overwrite-cli-url-check
branch
10 times, most recently
from
dec1fec to
141177c
Compare
nextcloud-command
force-pushed
the
enh/31429/improve-overwrite-cli-url-check
branch
from
141177c to
225cc2e
Compare
|
/backport to stable23 |
|
/backport to stable22 |
szaimen
requested review from
a team,
CarlSchwan,
nickvergessen and
skjnldsv
and removed request for
a team
szaimen
added
3. to review
szaimen
commented
Mar 3, 2022
nickvergessen
previously requested changes
Mar 4, 2022
szaimen
commented
Mar 4, 2022
nickvergessen
changed the title
overwrite.cli.url to be a url in setup check
szaimen
added
3. to review
szaimen
force-pushed
the
enh/31429/improve-overwrite-cli-url-check
branch
from
e0d48e9 to
1947ed3
Compare
juliusknorr
reviewed
Mar 4, 2022
szaimen
commented
Mar 4, 2022
Signed-off-by: szaimen <szaimen@e.mail.de>
szaimen
force-pushed
the
enh/31429/improve-overwrite-cli-url-check
branch
from
e58122e to
4191a17
Compare
szaimen
commented
Mar 9, 2022
| $suggestedOverwriteCliUrl = $this->request->getServerProtocol() . '://' . $this->request->getInsecureServerHost() . \OC::$WEBROOT; | ||
|
|
||
| // Check correctness by checking if it is a valid URL | ||
| if (filter_var($currentOverwriteCliUrl, FILTER_VALIDATE_URL)) { |
There was a problem hiding this comment.
Is everyone, especially @juliushaertl fine if we do it like this for now?
After merging, I will rebase Carls PR and change it there to use his validation logic but since I want to backport this we will not have the validation logic in place.
For me the most important change of this PR is to make admins aware of this config which the PR does. Since the warning is only shown in the admin panel, it is in my opinion no big problem if it is sometimes false-positive because of this unperfect filter and will not cause any harm.
juliusknorr
approved these changes
Mar 10, 2022
CarlSchwan
approved these changes
Mar 10, 2022
|
Thanks everyone! Merging then :) |
|
/backport to stable23 |
|
/backport to stable22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #31429
Signed-off-by: szaimen szaimen@e.mail.de