Skip to content

Commit e0d48e9

Browse files
committed
adress review
Signed-off-by: szaimen <szaimen@e.mail.de>
1 parent 225cc2e commit e0d48e9

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

apps/settings/lib/Controller/CheckSetupController.php

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -621,10 +621,8 @@ protected function getSuggestedOverwriteCliURL(): string {
621621
}
622622
}
623623

624-
// Check correctness by comparing with suggested URL
625-
// This might lead to false positives though but that is fine since you should access your Nextcloud via the here defined URL either way
626-
// In case of a false positive, simply ignore the suggestion
627-
if ($suggestedOverwriteCliUrl === rtrim($currentOverwriteCliUrl, "/")) {
624+
// Check correctness by checking if it is a valid URL
625+
if (filter_var($currentOverwriteCliUrl, FILTER_VALIDATE_URL)) {
628626
$suggestedOverwriteCliUrl = '';
629627
}
630628

0 commit comments

Comments
 (0)