Use the cache also for UserBackend::getPassword#31218
Merged
nickvergessen merged 2 commits intomasterfrom Mar 2, 2022
Merged
Conversation
nickvergessen
added
bug
3. to review
nickvergessen
requested review from
a team,
CarlSchwan,
PVince81 and
come-nc
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
techdebt/noid/use-cache-also-for-userbackend-getpassword
branch
from
97740e4 to
23ef02f
Compare
come-nc
approved these changes
Feb 17, 2022
Member
|
Tests are not happy :/ |
Signed-off-by: Joas Schilling <coding@schilljs.com>
Member
Author
|
Test fixed |
Member
|
acceptance test for users failed |
PVince81
added
4. to release
Member
|
@nickvergessen backport or too risky ? |
Member
Author
|
I would consider it after we know an instance that uses Database backend ran good for some days. |
nickvergessen
deleted the
techdebt/noid/use-cache-also-for-userbackend-getpassword
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Screenshot together with #31217 )