Skip to content

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Feb 16, 2022

Strips of a query per OCS request in my integration test runs.

Screenshot of the query log. The yellow one is the entry where we now cache the exception additionally
Bildschirmfoto von 2022-02-16 16-56-24

Signed-off-by: Joas Schilling <coding@schilljs.com>
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

though, using null or false might use less memory and be more intuitive than storing an exception

@nickvergessen
Copy link
Member Author

though, using null or false might use less memory and be more intuitive than storing an exception

But then we can not rethrow the previous exception and I did not want to go and check all places if something depends on the parent exception

@nickvergessen nickvergessen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 16, 2022
@nickvergessen nickvergessen merged commit 87115d8 into master Feb 21, 2022
@nickvergessen nickvergessen deleted the bugfix/noid/also-cache-non-existing-entry branch February 21, 2022 10:50
@nickvergessen
Copy link
Member Author

/backport to stable23

@nickvergessen
Copy link
Member Author

/backport to stable22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: authentication performance 🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants