Conversation
skjnldsv
approved these changes
Jan 24, 2022
Member
|
Code scanning results / Psalm Failing after 23s — 24 new alerts including 7 errors, 24 fixes |
44d9555 to
78e0af1
Compare
78e0af1 to
0262cc3
Compare
Member
|
Hmm 24 new and 24 fixed would be expected, but now it is 27 new and 24 fixed 🤔. Some annotations are clear mistakes, like |
MichaIng
approved these changes
Jan 25, 2022
ef63120 to
7fbb9df
Compare
Member
|
Please edit the checker :) |
7fbb9df to
a9605e4
Compare
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
a9605e4 to
57514e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #30508