Skip to content

Conversation

@kesselb
Copy link
Collaborator

@kesselb kesselb commented Jun 5, 2022

#30826 is partly a backport of #28507 but did not add the vendor-bin directory to .gitignore.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb added 2. developing Work in progress technical debt 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 5, 2022
@kesselb kesselb added this to the Nextcloud 22.2.9 milestone Jun 9, 2022
@szaimen
Copy link
Contributor

szaimen commented Jun 9, 2022

@kesselb are the three failing tests unrelated?

@blizzz blizzz mentioned this pull request Jun 9, 2022
@kesselb
Copy link
Collaborator Author

kesselb commented Jun 9, 2022

@kesselb are the three failing tests unrelated?

Good question 🤔

The purpose of this pull request is to make the psalm baseline update work for stable22. When you run composer install it will install some dependencies to vendor-bin. Those are usually for development (e.g. phpunit or psalm) and scoped (via vendor-bin plugin) to not interfere with the application dependencies. Right now those scoped tools are not excluded on stable22 so running the psalm baseline update will add a bunch of new files. Example: https://github.com/kesselb/server/pull/3/files (pull request title says master but it was for stable22). Adding vendor-bin to .gitignore will fix this issue and is already done for stable23, stable24, master.

Failing tests:

  1. samba: Is unreliable for quite a while. It's better with newer Nextcloud versions.
  2. acceptance-app-files-tags: Is also failing on master sometimes. Looks like timing issues with the headless browser.
  3. object-store-azure this looks bad indeed. However it's also failing for other stable22 ci runs. I don't think that has anything to do with a not installed development dependency.

image

@szaimen
Copy link
Contributor

szaimen commented Jun 9, 2022

All right! Thanks for the detailed explanation! Merging then!

@szaimen szaimen merged commit 93da8d8 into nextcloud:stable22 Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants