Use npm ci when running JS tests

[PVince81]

This makes sure that the pinned versions are selected correctly.
Fixes the colors.js incident.

This should make CI for JS tests work again.

[PVince81]

interesting... so the colors.js issue has disappeared, but now the errors on CI match what I always see locally.
I never understood how the tests could even pass on CI if they don't locally, probably an env discrepancy

so at least now the envs are aligned (at least for mine), so it looks like those issues will need solving also

[CarlSchwan]

interesting... so the colors.js issue has disappeared, but now the errors on CI match what I always see locally. I never understood how the tests could even pass on CI if they don't locally, probably an env discrepancy

so at least now the envs are aligned (at least for mine), so it looks like those issues will need solving also

We probably should update the dependencies and then pin the colors.js dependenfy to 1.4.0

[PVince81]

@CarlSchwan sounds like a good plan, I'll try that. Thanks

[PVince81]

I ran npm install with the pinned dep for colors and pushed the updated package-lock.json.
The same test errors still happen.

[PVince81]

I saw that recently more stuff got bundled into the JS files, even stuff that isn't supposed to auto-load during test runs. Causes some XHR to be done too early. Something to examine later.

I had a look at the contacts menu failure where 1 call to console.error is expected instead of 3.
The calls all look like this:

LOG LOG: '##### call 0: [Vue warn]: Cannot find element: #files-app-settings'
LOG LOG: '##### call 1: [Vue warn]: Cannot find element: #app-sidebar'
LOG LOG: '##### call 2: There was an error loading your contacts,[object Object]'

so possibly it's those additional bundles that get loaded that cause more side effects

[PVince81]

fixed the tests, they pass locally with Chromium and Firefox

[PVince81]

JSUnit passed! 🎉

[PVince81]

I've re-requested a review due to the changes being bigger.
Please have another look, thanks!

[artonge]

One step closer to making them work with npm 7 !

[PVince81]

/backport to stable23

[PVince81]

/backport to stable22

[PVince81]

/backport to stable21

[PVince81]

(I'm sure there will be backport conflicts, am already bracing for them...)

[artonge]

(I'm sure there will be backport conflicts, am already bracing for them...)

Maybe put build files into a separate commits so it eases backports

[PVince81]

(I'm sure there will be backport conflicts, am already bracing for them...)

Maybe put build files into a separate commits so it eases backports

ah, too late. in any case, I expect conflicts on package-lock perhaps

[backportbot-nextcloud]

The backport to stable23 failed. Please do this backport manually.

[backportbot-nextcloud]

The backport to stable22 failed. Please do this backport manually.

[backportbot-nextcloud]

The backport to stable21 failed. Please do this backport manually.

[PVince81]

• stable23: [stable23] Use npm ci when running JS tests #30580
• stable22: [stable22] Use npm ci when running JS tests #30581
• stable21: [stable21] Use npm ci when running JS tests #30583