Don't update packages in build/package-lock.json when running js-tests#28528
Don't update packages in build/package-lock.json when running js-tests#28528nickvergessen wants to merge 2 commits intomasterfrom
Conversation
|
Makes sense though we should also commit that properly then in the first run https://github.com/nextcloud/server/blob/master/build/package-lock.json and remove it from .gitignore |
49811ae to
dde32d7
Compare
Done, please review |
|
Are failing JS tests related? Works locally |
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
dde32d7 to
238f29e
Compare
|
As mentioned above, I have no idea. |
|
So anyone from @nextcloud/server-frontend wants to pick this up? Otherwise I would close it any we still have the updates happening |
Should be good as of: #30567 |
|
The .gitignore part would be nice to have though |
I find it quite distrubing to always end up with a modified
build/package-lock.jsonfile after running autotest-js.shUpdating should be done explicitly (or automatically with dependabot) and then be commited like that to the repo, not running locally when you run tests