[stable22] Only add the vue exeption to actual button elements#30010
Merged
[stable22] Only add the vue exeption to actual button elements#30010
Conversation
backportbot-nextcloud
bot
requested review from
GretaD,
Valdnet,
marcoambrosini,
skjnldsv and
st3iny
skjnldsv
approved these changes
Dec 1, 2021
Valdnet
approved these changes
Dec 1, 2021
MichaIng
previously requested changes
Dec 1, 2021
Member
MichaIng
left a comment
MichaIng
left a comment
There was a problem hiding this comment.
Some .button:not(.button-vue) cases are missing in this backport.
st3iny
dismissed
MichaIng’s stale review
It's fine because the original change to this line wasn't backported in the first place. This line looks like the same as it is on master.
Signed-off-by: marco <marcoambrosini@pm.me> Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3iny
force-pushed
the
backport/29905/stable22
branch
from
1f4717b to
10056ff
Compare
st3iny
approved these changes
Dec 7, 2021
Member
st3iny
left a comment
st3iny
left a comment
There was a problem hiding this comment.
I added the missing change and tested again.
Member
|
The jsunit failures are unrelated. But someone with insights should have a look: Looks like a formal thing where a template has changed, now containing |
MichaIng
approved these changes
Dec 7, 2021
Contributor
|
@marcoambrosini please have a look at this one so we can merge it as people that are on NC v22 are reporting problems |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #29905