-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only add the vue exeption to actual button elements #29905
Conversation
Signed-off-by: marco <marcoambrosini@pm.me>
Do you have examples of where this helps or not? I'm not able to verify it would actually fix the regressions |
There is this nextcloud-libraries/nextcloud-vue#2371 |
As for me, it works fine after the changes 👍. @marcoambrosini Thanks for the memory and fix 😉. |
will we backport to 22 as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes nextcloud-libraries/nextcloud-vue#2371 but does not fix #29591.
However, I just realized that the button regression in calendar is caused by a local css rule. We should fix it in the calendar repo directly.
PS: I could not reproduce the reply button problem from #29591. It's working fine for me with and without this patch. |
Yes I think we should |
if you backport to 22, backport to 23, too |
/backport to stable23 |
/backport to stable22 |
Fixes #29591