Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only add the vue exeption to actual button elements #29905

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

marcoambrosini
Copy link
Member

@marcoambrosini marcoambrosini commented Nov 25, 2021

Fixes #29591

Signed-off-by: marco <marcoambrosini@pm.me>
@marcoambrosini marcoambrosini self-assigned this Nov 25, 2021
@marcoambrosini marcoambrosini added 3. to review Waiting for reviews design Design, UI, UX, etc. labels Nov 25, 2021
@ChristophWurst
Copy link
Member

Do you have examples of where this helps or not? I'm not able to verify it would actually fix the regressions

@marcoambrosini
Copy link
Member Author

There is this nextcloud-libraries/nextcloud-vue#2371
Maybe it's too late for this?

@Valdnet
Copy link
Contributor

Valdnet commented Nov 25, 2021

As for me, it works fine after the changes 👍.

@marcoambrosini Thanks for the memory and fix 😉.

@ChristophWurst
Copy link
Member

will we backport to 22 as well?

Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes nextcloud-libraries/nextcloud-vue#2371 but does not fix #29591.

However, I just realized that the button regression in calendar is caused by a local css rule. We should fix it in the calendar repo directly.

@st3iny
Copy link
Member

st3iny commented Dec 1, 2021

PS: I could not reproduce the reply button problem from #29591. It's working fine for me with and without this patch.

@ChristophWurst ChristophWurst merged commit 17c901b into master Dec 1, 2021
@ChristophWurst ChristophWurst deleted the bugfix/fix-some-buttons branch December 1, 2021 10:38
@marcoambrosini
Copy link
Member Author

will we backport to 22 as well?

Yes I think we should

@blizzz blizzz added this to the Nextcloud 24 milestone Dec 1, 2021
@blizzz
Copy link
Member

blizzz commented Dec 1, 2021

if you backport to 22, backport to 23, too

@skjnldsv
Copy link
Member

skjnldsv commented Dec 1, 2021

/backport to stable23

@skjnldsv
Copy link
Member

skjnldsv commented Dec 1, 2021

/backport to stable22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Design, UI, UX, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button regressions in 23
6 participants