Scope composer tools with the bin plugin#28507
Merged
ChristophWurst merged 1 commit intomasterfrom Aug 19, 2021
Merged
Conversation
Member
Author
|
Neat side effect: when you |
CarlSchwan
approved these changes
Aug 19, 2021
2 tasks
juliusknorr
reviewed
Aug 19, 2021
Member
|
|
Member
Author
Yes but no :P What I don't like about that is that you get different autoloaders for This might be a purely theoretical problem. The other solution I'm fine with would be to just vendor the lib together with #28509. |
juliusknorr
approved these changes
Aug 19, 2021
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
e13d55c to
e3541da
Compare
skjnldsv
approved these changes
Aug 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This puts our current dev tools into isolation, so they and their dependencies won't interfere with vendored production dependencies.
Ref https://github.com/bamarni/composer-bin-plugin for those new to this plugin
Summary
Changes for developers: ✨none✨
The same trick has been used in Mail for months. It helped us get rid of tools that pulled in incompatible versions of Symfony.