[19] limit constructing of result objects in file search#26073
Merged
MorrisJobke merged 1 commit intostable19from Mar 18, 2021
Merged
[19] limit constructing of result objects in file search#26073MorrisJobke merged 1 commit intostable19from
MorrisJobke merged 1 commit intostable19from
Conversation
icewind1991
force-pushed
the
search-file-limit-results-19
branch
from
03d8722 to
ee73220
Compare
icewind1991
added
3. to review
even thought we currently have no proper way of limiting the search itself, we can at least limit the construction of the result objects. this saves about 40% of the time spend in the search request in my local testing Signed-off-by: Robin Appelman <robin@icewind.nl>
PVince81
force-pushed
the
search-file-limit-results-19
branch
from
ee73220 to
df77c7d
Compare
Member
|
rebased for CI |
MorrisJobke
added
4. to release
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #26049 to stable19