limit constructing of result objects in file search #26049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks happy enough to me? |
even thought we currently have no proper way of limiting the search itself, we can at least limit the construction of the result objects. this saves about 40% of the time spend in the search request in my local testing Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
search-file-limit-results
branch
from
12fdc19
to
84b2d02
Compare
|
extended it to also work for the old search endpoint (mainly for backport reasons) |
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
search-file-limit-results
branch
from
84b2d02
to
b62ee57
Compare
rullzer
approved these changes
Mar 12, 2021
|
/backport to stable21 |
|
/backport to stable20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
even thought we currently have no proper way of limiting the search itself, we can at least limit the construction of the result objects.
this saves about 40% of the time spend in the search request in my local testing when the search query matches a large number of files.
Signed-off-by: Robin Appelman robin@icewind.nl