Skip to content

extend cache events #24113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 2, 2020
Merged

extend cache events #24113

merged 3 commits into from
Dec 2, 2020

Conversation

@icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Nov 13, 2020 •
edited by MorrisJobke
Loading

  • adds cache remove event
  • expose storage id in event
  • emit events during cache move

Once merged:

Signed-off-by: Robin Appelman robin@icewind.nl

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Nov 13, 2020
@icewind1991 icewind1991 added this to the Nextcloud 21 milestone Nov 13, 2020
@nextcloud nextcloud deleted a comment from faily-bot bot Nov 14, 2020
rullzer
rullzer reviewed Nov 16, 2020
View reviewed changes
ChristophWurst
ChristophWurst reviewed Nov 17, 2020
View reviewed changes
MorrisJobke
MorrisJobke reviewed Nov 19, 2020
View reviewed changes
@icewind1991
extend cache events
23fb497 
- adds cache remove event
- expose storage id in event
- emit events during cache move

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
rename cache event to follow new naming standards
88f35d5 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
Copy link
Member Author

renamed the events

MorrisJobke
MorrisJobke reviewed Nov 30, 2020
View reviewed changes
MorrisJobke
MorrisJobke requested changes Nov 30, 2020
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code style needs to be run but then it looks good 👍

@MorrisJobke MorrisJobke added the pending documentation This pull request needs an associated documentation update label Nov 30, 2020
@icewind1991
code style and dispatchTyped
aef1cdb 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
Copy link
Member Author

code style needs to be run but then it looks good

done

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 2, 2020
@rullzer rullzer merged commit 6f4d3ed into master Dec 2, 2020
@rullzer rullzer deleted the extend-cache-events branch December 2, 2020 18:48
@MorrisJobke MorrisJobke mentioned this pull request Dec 2, 2020
Closed
@MorrisJobke MorrisJobke removed the pending documentation This pull request needs an associated documentation update label Dec 2, 2020
@icewind1991
Copy link
Member Author

/backport to stable20

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 13, 2021
Merged
This was referenced Sep 19, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer left review comments

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 21

Development

Successfully merging this pull request may close these issues.

5 participants

@icewind1991 @rullzer @MorrisJobke @ChristophWurst