Skip to content

[stable20] extend cache events #28820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 16, 2021
Merged

[stable20] extend cache events #28820

merged 5 commits into from
Sep 16, 2021

Conversation

@backportbot-nextcloud
Copy link

backport of #24113

@icewind1991 @backportbot
extend cache events
11e81b3 
- adds cache remove event
- expose storage id in event
- emit events during cache move

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @backportbot
rename cache event to follow new naming standards
e923478 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @backportbot
code style and dispatchTyped
5e8e252 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 20.0.13 milestone Sep 13, 2021
@icewind1991
update @SInCE for backport
1ed2550 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 mentioned this pull request Sep 13, 2021
Closed
@AndyScherzinger AndyScherzinger requested review from skjnldsv and removed request for MorrisJobke September 13, 2021 20:44
@icewind1991 icewind1991 requested review from juliusknorr and removed request for rullzer September 15, 2021 12:11
blizzz
blizzz approved these changes Sep 16, 2021
View reviewed changes
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming (and finding to proof that is is otherwise) that CacheInsertEvent and CacheUpdateEvent are constructed internally only, as otherwise it would break compatibility for the changed constructor.

@icewind1991
make event constructor backwards compatible just in case
c0b701f 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
Copy link
Member

assuming (and finding to proof that is is otherwise) that CacheInsertEvent and CacheUpdateEvent are constructed internally only, as otherwise it would break compatibility for the changed constructor.

Added a default value for fallback just in case

@icewind1991 icewind1991 merged commit c7ab27c into stable20 Sep 16, 2021
@icewind1991 icewind1991 deleted the backport/24113/stable20 branch September 16, 2021 14:08
@blizzz blizzz mentioned this pull request Sep 23, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blizzz blizzz blizzz approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Nextcloud 20.0.13

Development

Successfully merging this pull request may close these issues.

4 participants

@icewind1991 @blizzz @skjnldsv