Skip to content

Conversation

@backportbot-nextcloud
Copy link

backport of #23744

…State closure with Psalm

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@MorrisJobke MorrisJobke added the 4. to release Ready to be released and/or waiting for tests to finish label Oct 28, 2020
@faily-bot
Copy link

faily-bot bot commented Oct 28, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 34685: failure

acceptance-header

  • tests/acceptance/features/header.feature:33
Show full log
  Scenario: users from other groups are not seen in the contacts menu when autocompletion is restricted within the same group # /drone/src/tests/acceptance/features/header.feature:33
    Given I am logged in as the admin                                                                                         # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I visit the settings page                                                                                             # SettingsMenuContext::iVisitTheSettingsPage()
    And I open the "Sharing" section of the "Administration" group                                                            # AppNavigationContext::iOpenTheSectionOf()
    And I enable restricting username autocompletion to groups                                                                # SettingsContext::iEnableRestrictingUsernameAutocompletionToGroups()
    And I see that username autocompletion is restricted to groups                                                            # SettingsContext::iSeeThatUsernameAutocompletionIsRestrictedToGroups()
    When I open the Contacts menu                                                                                             # ContactsMenuContext::iOpenTheContactsMenu()
    Then I see that the Contacts menu is shown                                                                                # ContactsMenuContext::iSeeThatTheContactsMenuIsShown()
    And I see that the contact "user0" in the Contacts menu is not shown                                                      # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsNotShown()
      Failed asserting that true is false.
    And I see that the contact "admin" in the Contacts menu is not shown                                                      # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsNotShown()

@MorrisJobke MorrisJobke merged commit bce4ca7 into stable20 Oct 28, 2020
@MorrisJobke MorrisJobke deleted the backport/23744/stable20 branch October 28, 2020 20:10
@rullzer rullzer mentioned this pull request Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug enhancement technical debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants