Skip to content

Disable unreliable app-files-sharing.feature:338 #23614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2020
Merged

Disable unreliable app-files-sharing.feature:338 #23614

merged 1 commit into from
Oct 22, 2020

Conversation

@MorrisJobke
Copy link
Member

#22305 (comment)

cc @danxuliu sorry, but it fails quite often and it just hurts the other CI jobs.

@MorrisJobke
Disable unreliable app-files-sharing.feature:108
dff9853 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke added this to the Nextcloud 21 milestone Oct 21, 2020
@MorrisJobke
Copy link
Member Author

/backport to stable20

@MorrisJobke
Copy link
Member Author

/backport to stable19

@MorrisJobke
Copy link
Member Author

/backport to stable18

@MorrisJobke MorrisJobke mentioned this pull request Oct 21, 2020
Closed
@faily-bot
Copy link

faily-bot bot commented Oct 21, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 34421: failure

mariadb10.1-php7.3

Show full log 
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\Cache\QuerySearchHelperTest::testComparison with data set #4 (OC\Files\Search\SearchComparison Object (...), array(0))
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
-    0 => 0
+    0 => '431'
 )

/drone/src/tests/lib/Files/Cache/QuerySearchHelperTest.php:212

danxuliu
danxuliu approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @danxuliu sorry, but it fails quite often and it just hurts the other CI jobs.

No problem, thanks for doing the clean up :-)

@MorrisJobke MorrisJobke merged commit a747057 into master Oct 22, 2020
@MorrisJobke MorrisJobke deleted the tests/22305/unreliable-app-files-sharing-338 branch October 22, 2020 10:19
This was referenced Oct 22, 2020
Merged
Merged
Merged
@danxuliu danxuliu changed the title Disable unreliable app-files-sharing.feature:108 Disable unreliable app-files-sharing.feature:338 Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@danxuliu danxuliu danxuliu approved these changes

@rullzer rullzer Awaiting requested review from rullzer

Assignees

No one assigned

Labels

3. to review Waiting for reviews technical debt

Projects

None yet

Milestone

Nextcloud 21

Development

Successfully merging this pull request may close these issues.

5 participants

@MorrisJobke @ChristophWurst @skjnldsv @danxuliu