Skip to content

[stable19] Fix undefined index and consequential damages in versions code #23424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 24, 2020
Merged

[stable19] Fix undefined index and consequential damages in versions code #23424

merged 2 commits into from
Oct 24, 2020

Conversation

@backportbot-nextcloud
Copy link

backport of #23295

ChristophWurst and others added 2 commits October 13, 2020 15:46
@ChristophWurst @backportbot
Fix undefined index and consequential damages in versions code
92ac576 
If the user has no space and there are no versions, there won't be an
`all` index in the versions entry. Hence this triggers a warning and
becomes `null`, afterwards `count`, `foreach` and friends will happily
throw even more warnings and errors because they don't want to play with
`null`. Thus adding a fallback to an empty array.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@MorrisJobke @backportbot
Return all keys in getAllVersions() instead
2642509 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 19.0.5 milestone Oct 13, 2020
MorrisJobke
MorrisJobke approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Oct 13, 2020
@faily-bot
Copy link

faily-bot bot commented Oct 13, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 34091: failure

sqlite

Show full log 
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\Cache\UpdaterLegacyTest::testWrite
Failed asserting that 1602612817 is equal to 1602612818 or is greater than 1602612818.

/drone/src/tests/lib/Files/Cache/UpdaterLegacyTest.php:118

integration-sharees-features

Could not fetch logs

@MorrisJobke MorrisJobke mentioned this pull request Oct 13, 2020
Closed
@rullzer rullzer merged commit 353412b into stable19 Oct 24, 2020
@rullzer rullzer deleted the backport/23295/stable19 branch October 24, 2020 09:01
@rullzer rullzer mentioned this pull request Nov 9, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug feature: versions

Projects

None yet

Milestone

Nextcloud 19.0.5

Development

Successfully merging this pull request may close these issues.

4 participants

@rullzer @MorrisJobke @ChristophWurst