Skip to content

Conversation

@ChristophWurst
Copy link
Member

The public API said string, internally we treated it as int. In reality
both are used. Let's reflect that in the documented argument type.

Found in https://github.com/nextcloud/server/pull/23401/checks?check_run_id=1246541334

The public API said string, internally we treated it as int. In reality
both are used. Let's reflect that in the documented argument type.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@faily-bot
Copy link

faily-bot bot commented Oct 13, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 34062: failure

acceptance-apps

  • tests/acceptance/features/apps.feature:34
Show full log
  Scenario: Browse app bundles                           # /drone/src/tests/acceptance/features/apps.feature:34
    Given I act as Jane                                  # ActorContext::iActAs()
    And I am logged in as the admin                      # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the Apps management                       # SettingsMenuContext::iOpenTheAppsManagement()
    When I open the "App bundles" section                # AppNavigationContext::iOpenTheSection()
    Then I see that the current section is "App bundles" # AppNavigationContext::iSeeThatTheCurrentSectionIs()
    And I see the app bundles                            # AppsManagementContext::iSeeTheAppBundles()
      Row for app Auditing / Logging in Apps Management could not be found after 20 seconds (NoSuchElementException)
    And I see that the "Enterprise bundle" is disabled   # AppsManagementContext::iSeeThatTheIsDisabled()

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 13, 2020
@MorrisJobke MorrisJobke merged commit 776c65d into master Oct 13, 2020
@MorrisJobke MorrisJobke deleted the fix/encryption-decrypt-position-type branch October 13, 2020 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug technical debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants