Skip to content

Only retry fetching app store data once every 5 minutes in case it fails #23374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2020
Merged

Only retry fetching app store data once every 5 minutes in case it fails #23374

merged 1 commit into from
Oct 20, 2020

Conversation

@juliusknorr
Copy link
Member

Reduce the amount of requests going to the app store in case that it is slow anyways

@juliusknorr juliusknorr added this to the Nextcloud 21 milestone Oct 12, 2020
MorrisJobke
MorrisJobke approved these changes Oct 12, 2020
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 12, 2020
@kesselb
Copy link
Collaborator

kesselb commented Oct 12, 2020 •
edited
Loading

I'm not a fan ;) Most people still have a old version around. I would suggest to return the old version and queue a background job to update the apps.json. Anything else is just ducktaping ;)

But yes this one is easy to backport.

nickvergessen
nickvergessen reviewed Oct 12, 2020
View reviewed changes
lib/private/App/AppStore/Fetcher/Fetcher.php Outdated
Comment on lines 194 to 191
if (empty($responseJson['data'])) {
return [];
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Throw a ConnectException in the fetch instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if there might be cases where an empty response would be valid in case there are no releases for the Nextcloud version for example, so I'd rather keep the logic for now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In any case this should be a different exception then, since there is no connection happening. Also logging this every time should then only be done on debug/info level I guess. But for the sake of backporting I'd keep the changes minimal for now.

nickvergessen
nickvergessen reviewed Oct 12, 2020
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the general idea, not sure if we should save it in the cache (most 1-user instances might not have one and therefor still cause the most issues).
Maybe we store it either in the file or the appconfig instead?

@MorrisJobke MorrisJobke added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Oct 13, 2020
@juliusknorr
Copy link
Member Author

Maybe we store it either in the file or the appconfig instead?

Yeah, makes sense. I'll adjust that.

@juliusknorr juliusknorr force-pushed the bugfix/noid/app-fetch-retry branch from ca3cb7f to 9e94896 Compare October 14, 2020 15:20
MorrisJobke
MorrisJobke reviewed Oct 14, 2020
View reviewed changes
@juliusknorr juliusknorr force-pushed the bugfix/noid/app-fetch-retry branch from d5991fc to 4512c73 Compare October 16, 2020 12:33
@rullzer rullzer merged commit ffd76d0 into master Oct 20, 2020
@rullzer rullzer deleted the bugfix/noid/app-fetch-retry branch October 20, 2020 07:21
@nickvergessen
Copy link
Member

/backport to stable20

@nickvergessen
Copy link
Member

/backport to stable19

@nickvergessen
Copy link
Member

/backport to stable18

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 22, 2020
Merged
This was referenced Oct 22, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

No one assigned

Labels

2. developing Work in progress bug feature: apps management

Projects

None yet

Milestone

Nextcloud 21

Development

Successfully merging this pull request may close these issues.

7 participants

@juliusknorr @kesselb @nickvergessen @MorrisJobke @skjnldsv @rullzer