Skip to content

[stable18] Only retry fetching app store data once every 5 minutes in case it fails #23635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2020
Merged

[stable18] Only retry fetching app store data once every 5 minutes in case it fails #23635

merged 1 commit into from
Nov 9, 2020

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Oct 22, 2020 •
edited by juliusknorr
Loading

⚠️ This backport had conflicts and is incomplete ⚠️ Resolved manually.

backport of #23374

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 18.0.11 milestone Oct 22, 2020
@rullzer rullzer added the 3. to review Waiting for reviews label Oct 24, 2020
@nickvergessen
Copy link
Member

Failing tests are related!

@nickvergessen nickvergessen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Oct 27, 2020
@rullzer rullzer mentioned this pull request Nov 9, 2020
Merged
2 tasks
@juliusknorr juliusknorr force-pushed the backport/23374/stable18 branch from f6a69e1 to 338498f Compare November 9, 2020 10:47
@juliusknorr
Copy link
Member

Fixed the conflict, tests should run fine now

@juliusknorr juliusknorr added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 9, 2020
@juliusknorr juliusknorr removed their assignment Nov 9, 2020
@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 9, 2020
@faily-bot
Copy link

faily-bot bot commented Nov 9, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 35259: failure

handlebars

@MorrisJobke MorrisJobke merged commit c6abcfb into stable18 Nov 9, 2020
@MorrisJobke MorrisJobke deleted the backport/23374/stable18 branch November 9, 2020 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: apps management

Projects

None yet

Milestone

Nextcloud 18.0.11

Development

Successfully merging this pull request may close these issues.

6 participants

@nickvergessen @juliusknorr @MorrisJobke @skjnldsv @rullzer