Skip to content

Conversation

@blizzz
Copy link
Member

@blizzz blizzz commented Sep 10, 2020

add user and group backend first, before announcing them. User and group may have close relationships with each other, so announce one to early might be too early. For instance, the own LDAPProvider, which is accessible as a service from the server container. That's not the best solution, but the quickest for now.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@faily-bot
Copy link

faily-bot bot commented Sep 10, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32983: failure

mysql8.0-php7.2

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\Cache\ScannerTest::testRemovedFile
Failed asserting that false is true.

/drone/src/tests/lib/Files/Cache/ScannerTest.php:287

@rullzer rullzer mentioned this pull request Sep 11, 2020
5 tasks
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

@MorrisJobke MorrisJobke merged commit 8ab2d5a into master Sep 11, 2020
@MorrisJobke MorrisJobke deleted the fix/noid/ldap-backend-added-post-events branch September 11, 2020 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants