Skip to content

implements ibootstrap and cleans up code #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 15, 2020
Merged

implements ibootstrap and cleans up code #205

merged 2 commits into from
Oct 15, 2020

Conversation

@blizzz
Copy link
Member

@blizzz blizzz commented Sep 10, 2020 •
edited
Loading

juliusknorr
juliusknorr reviewed Sep 11, 2020
View reviewed changes
juliusknorr
juliusknorr reviewed Sep 11, 2020
View reviewed changes
juliusknorr
juliusknorr reviewed Sep 11, 2020
View reviewed changes
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some coding leftovers it seems otherwise 👍

@blizzz blizzz force-pushed the fix/noid/ibootstrap branch from 9992f21 to 6100b8b Compare October 14, 2020 16:08
ChristophWurst
ChristophWurst requested changes Oct 14, 2020
View reviewed changes
@ChristophWurst ChristophWurst added the enhancement New feature or request label Oct 14, 2020
@blizzz
implements ibootstrap and cleans up code
b9eabd3 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz force-pushed the fix/noid/ibootstrap branch from 6100b8b to b9eabd3 Compare October 15, 2020 09:25
@blizzz blizzz requested a review from ChristophWurst October 15, 2020 09:26
@blizzz
bump master to 21
ffe2d31 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
ChristophWurst
ChristophWurst approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@blizzz blizzz requested a review from juliusknorr October 15, 2020 09:36
@blizzz blizzz merged commit 7c4cd1f into master Oct 15, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix/noid/ibootstrap branch October 15, 2020 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@blizzz @ChristophWurst @juliusknorr