Skip to content

Conversation

nickvergessen
Copy link
Member

No description provided.

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 Also the move of the count functionality into the SQL statement is a good catch 🚀

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/429-on-brute-force-maximum branch from 4bdae65 to 6f5f71d Compare August 19, 2020 09:21
@nickvergessen
Copy link
Member Author

Rebased and fixed the tests

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member Author

Not sure whats going on with the psalm thing and how to fix this. @MorrisJobke

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@faily-bot
Copy link

faily-bot bot commented Aug 19, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31983: failure

mysql8.0-php7.2

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\Cache\UpdaterLegacyTest::testWriteWithMountPoints
Failed asserting that two strings are not identical.

/drone/src/tests/lib/Files/Cache/UpdaterLegacyTest.php:139

@MorrisJobke
Copy link
Member

The fix for the static code analysis is in #22304

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From me again 👍

@MorrisJobke MorrisJobke merged commit 4c6eb96 into master Aug 19, 2020
@MorrisJobke MorrisJobke deleted the bugfix/noid/429-on-brute-force-maximum branch August 19, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants