Use matching parameter names form interfaces and implementations #22304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MorrisJobke
requested review from
rullzer,
nickvergessen,
georgehrke,
ChristophWurst,
blizzz,
juliusknorr,
kesselb and
skjnldsv
ChristophWurst
approved these changes
Aug 19, 2020
Found by Psalm 3.14.1 Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
force-pushed
the
techdebt/noid/matching-param-names
branch
from
61d621f to
4db7829
Compare
MorrisJobke
added
4. to release
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by Psalm 3.14.1
That's the new feature of Psalm 3.14 vs 3.13 @nickvergessen ;) Thus it popped up in your PR.
It basically just renames parameters to match the ones of the interface and fixes two wrong PHPDoc blocks that contained a comma right behind the return value.