SSE: make legacy format opt in

[rullzer]

Basically a switch (off by default for new installations) to support the legacy format or not.
This should hopefully allow us to kill the old ways at some point.

Future work:

• Write docs
• Setupcheck that checks for the config.php flag and links to the docs where we explain this a77c891
• occ command to scan the files to see if there are any files that use the old format

[MorrisJobke]

• Setupcheck that checks for the config.php flag and links to the docs where we explain this a77c891

Done

[nickvergessen]

Bail out immediately when you found a negative one.

[nickvergessen]

🦈

[nickvergessen]

Some failing tests are related, others need a rebase

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31974: failure

mysql5.6-php7.2

Show full log

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\ObjectStore\ObjectStoreStorageTest::testCopy with data set #5 ('/sòurcē.txt', '/target.txt')
Expected /target.txt to be a copy of /drone/src/tests/data/lorem.txt
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.\n
-Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.\n
-Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur.\n
-Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.'
+''

/drone/src/tests/lib/Files/Storage/Storage.php:222
/drone/src/tests/lib/Files/Storage/Storage.php:235

acceptance-app-files

• tests/acceptance/features/app-files.feature:108

Show full log

  Scenario: show shares                                               # /drone/src/tests/acceptance/features/app-files.feature:108
    Given I am logged in                                              # LoginPageContext::iAmLoggedIn()
    And I share the link for "welcome.txt"                            # FilesAppSharingContext::iShareTheLinkFor()
    When I open the "Shares" section                                  # AppNavigationContext::iOpenTheSection()
    Then I see that the current section is "Shares"                   # AppNavigationContext::iSeeThatTheCurrentSectionIs()
    Then I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
      Row for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)

[rullzer]

Writing the docs is on my list for tomorrow

[rullzer]

/backport to stable19

[kesselb]

Don't forget the documentation :) We already have on issue report for the new setup check: #22478

[AndyXheli]

@rullzer What dose it mean by legacy format i enabled server side encryption when i installed NC 18. Do we need to stop using server side encryption ?

[weizenspreu]

@axheli Legacy format here means the encryption scheme that was used before authenticated encryption was introduced back in 2016. When you first started using the SSE with NC 18 you are not using the legacy format.

[kesselb]

I guess it's safe to ignore the warning for now. The condition to show the warning is wrong.

[AndyXheli]

@yahesh Got it thank you so much for explaining it.

[nickvergessen]

Run occ encryption:scan:legacy-format to see which files use the legacy format.

[AndyXheli]

@nickvergessen running it. Going to check it out! I have a few servers but I think this one was created a long time ago.