Skip to content

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Aug 24, 2020

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #22218

Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The migration step is not there currently but this will allow for the scanning and the disabling of the legacy encryption.

Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@rullzer
Copy link
Member

rullzer commented Aug 24, 2020

/backport to stable18

@rullzer
Copy link
Member

rullzer commented Aug 24, 2020

/backport to stable17

* Systems that upgrade have this enabled by default
* New systems disable it
* We'll have to add some wargning in the setup checks if this is enabled

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer force-pushed the backport/22218/stable19 branch from a468007 to d8c9589 Compare August 24, 2020 09:50
@faily-bot
Copy link

faily-bot bot commented Aug 24, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32232: failure

mariadb10.1-php7.2

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) OCA\Files_Versions\Tests\VersioningTest::testRestoreMovedShare
File content has not changed
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'version 2'
+'version 1'

/drone/src/apps/files_versions/tests/VersioningTest.php:730

mysql8.0-php7.2

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\Cache\Wrapper\CachePermissionsMaskTest::testGetFolderContentMasked with data set #0 (31)
Failed asserting that actual size 0 matches expected size 2.

/drone/src/tests/lib/Files/Cache/Wrapper/CachePermissionsMaskTest.php:76

@rullzer rullzer merged commit cf26716 into stable19 Aug 24, 2020
@rullzer rullzer deleted the backport/22218/stable19 branch August 24, 2020 10:18
This was referenced Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants