Deprecate the internal Symfony dispatcher adapter #21848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This type is not known on the public API, yet we should make sure that any usage of this class is noticed and migrated as soon as possible. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
requested review from
MorrisJobke,
blizzz,
julien-nc,
kesselb and
rullzer
MorrisJobke
approved these changes
Jul 15, 2020
kesselb
approved these changes
Jul 15, 2020
MorrisJobke
deleted the
techdebt/deprecate-internal-symfony-dispatcher-adapter
branch
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This type is not known on the public API, yet we should make sure that
any usage of this class is noticed and migrated as soon as possible.
IMO deprecation makes sense for internals as well as phpstorm and other decent IDEs show deprecated API usages in a distinctive styling.
Related to #21322, the change of the public API.