Skip to content

Deprecate \OCP\IServerContainer::getEventDispatcher #21322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2020
Merged

Deprecate \OCP\IServerContainer::getEventDispatcher #21322

merged 1 commit into from
Jun 9, 2020

Conversation

@ChristophWurst
Copy link
Member

No description provided.

@ChristophWurst
Deprecate \OCP\IServerContainer::getEventDispatcher
fec3fef 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added bug 3. to review Waiting for reviews pending documentation This pull request needs an associated documentation update labels Jun 8, 2020
@ChristophWurst ChristophWurst added this to the Nextcloud 20 milestone Jun 8, 2020
@ChristophWurst ChristophWurst self-assigned this Jun 8, 2020
@ChristophWurst ChristophWurst mentioned this pull request Jun 8, 2020
Closed
@ChristophWurst
Copy link
Member Author

I had a deja vu when I changed this. Turns out I did this for the implementation already in 18

server/lib/private/Server.php

Line 2030 in 6aa6ab3

* @deprecated 18.0.0 use \OCP\EventDispatcher\IEventDispatcher
. I guess due to my mistake I'll have to now wait three years until this can be removed, or do we accept a retroactive deprecation, like updating this to 18 here and backporting the annotation?

@rullzer rullzer merged commit 3f07485 into master Jun 9, 2020
@rullzer rullzer deleted the techdebt/deprecate-iservercontainer-geteventdispatcher branch June 9, 2020 08:32
@ChristophWurst ChristophWurst mentioned this pull request Jul 15, 2020
Merged
@ChristophWurst
Copy link
Member Author

Documented in nextcloud/documentation#5160

@ChristophWurst ChristophWurst removed the pending documentation This pull request needs an associated documentation update label Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@kesselb kesselb kesselb approved these changes

@blizzz blizzz Awaiting requested review from blizzz

Assignees

@ChristophWurst ChristophWurst

Labels

3. to review Waiting for reviews bug

Projects

None yet

Milestone

Nextcloud 20

Development

Successfully merging this pull request may close these issues.

6 participants

@ChristophWurst @rullzer @nickvergessen @juliusknorr @kesselb