Skip to content

[stable 17] Fix removing groups that have a slash in the name #18257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2019
Merged

[stable 17] Fix removing groups that have a slash in the name #18257

merged 1 commit into from
Dec 7, 2019

Conversation

@gary-kim
Copy link
Member

@gary-kim gary-kim commented Dec 5, 2019

Backport of #18228

@gary-kim gary-kim added bug 3. to review Waiting for reviews labels Dec 5, 2019
@gary-kim gary-kim added this to the Nextcloud 17.0.2 milestone Dec 5, 2019
@gary-kim gary-kim changed the title Fix removing groups that have a slash in the name [stable 17] Fix removing groups that have a slash in the name Dec 5, 2019
@gary-kim
Copy link
Member Author

gary-kim commented Dec 5, 2019

/backport to stable16

@gary-kim
Copy link
Member Author

gary-kim commented Dec 5, 2019

/backport to stable15

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 6, 2019
@gary-kim
Copy link
Member Author

gary-kim commented Dec 6, 2019

/compile amend /

@kesselb kesselb mentioned this pull request Dec 6, 2019
Closed
@gary-kim
Fix removing groups that have a slash in the name
e98b6f7 
Signed-off-by: Gary Kim <gary@garykim.dev>
@gary-kim gary-kim force-pushed the backport/18228/delete-group-with-slash-in-name branch from 00a8132 to e98b6f7 Compare December 7, 2019 02:19
@skjnldsv skjnldsv merged commit 2668ca7 into stable17 Dec 7, 2019
@skjnldsv skjnldsv deleted the backport/18228/delete-group-with-slash-in-name branch December 7, 2019 08:46
@backportbot-nextcloud
Copy link

The backport to stable16 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable15 failed. Please do this backport manually.

@skjnldsv
Copy link
Member

/backport to stable16

@skjnldsv
Copy link
Member

/backport to stable15

@skjnldsv
Copy link
Member

Ah well, we should not need 15 as this is EOL

@backportbot-nextcloud
Copy link

The backport to stable15 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable16 failed. Please do this backport manually.

@skjnldsv
Copy link
Member

Care to manually backport to stable16 @gary-kim :)

@gary-kim
Copy link
Member Author

gary-kim commented Apr 10, 2020 •
edited
Loading

Care to manually backport to stable16 @gary-kim :)

Can do!

EDIT: Wait... #18284

Just being honest, I checked out to the stable16 branch and found the file, noticed that the fix was already there. I had to use git blame to realize that it was me. 🤣
image

@MorrisJobke
Copy link
Member

EDIT: Wait... #18284

@gary-kim Thanks for the manual backports 👍 Could I ask you to remove the "backport-request" label from PRs that are backported? In this way we can easily find the closed PRs with this label that haven't been backported yet. :) Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GretaD GretaD GretaD approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Milestone

Nextcloud 17.0.2

Development

Successfully merging this pull request may close these issues.

5 participants

@gary-kim @skjnldsv @MorrisJobke @GretaD