Skip to content

Conversation

@gary-kim
Copy link
Member

@gary-kim gary-kim commented Dec 4, 2019

Closes #18211

Fix removing groups that have a slash in the name such as /test.

I will backport manually once this is merged.

@gary-kim gary-kim added 3. to review Waiting for reviews bug labels Dec 4, 2019
@gary-kim gary-kim added this to the Nextcloud 18 milestone Dec 4, 2019
Copy link
Member Author

@gary-kim gary-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add some acceptance tests

EDIT: Oh, acceptance tests for this are currently disabled because of a needed patch?

Scenario: create and delete a group
Given I act as Jane
And I am logged in as the admin
And I open the User settings
And I see that the list of users contains the user user0
# disabled because we need the TAB patch:
# https://github.com/minkphp/MinkSelenium2Driver/pull/244
# And I assign the user user0 to the group Group1

@skjnldsv Do you think these could be reenabled now? Should probably be a different PR.

@skjnldsv
Copy link
Member

skjnldsv commented Dec 4, 2019

@skjnldsv Do you think these could be reenabled now? Should probably be a different PR.

Highly doubt it, we're late by one major on selenium.
Too hard to upgrade.
We need to migrate our tests to cypress

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 4, 2019
@rullzer
Copy link
Member

rullzer commented Dec 4, 2019

Needs a rebase

Signed-off-by: Gary Kim <gary@garykim.dev>
@gary-kim gary-kim force-pushed the fix/18211/delete-group-with-slash-in-name branch from a83e1f2 to 5ae3860 Compare December 4, 2019 20:10
@gary-kim
Copy link
Member Author

gary-kim commented Dec 4, 2019

@rullzer Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove group with slash in the name impossible

5 participants