- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 4.6k
Fix removing groups that have a slash in the name #18228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should add some acceptance tests
EDIT: Oh, acceptance tests for this are currently disabled because of a needed patch?
server/tests/acceptance/features/users.feature
Lines 71 to 79 in 81b919e
| Scenario: create and delete a group | |
| Given I act as Jane | |
| And I am logged in as the admin | |
| And I open the User settings | |
| And I see that the list of users contains the user user0 | |
| # disabled because we need the TAB patch: | |
| # https://github.com/minkphp/MinkSelenium2Driver/pull/244 | |
| # And I assign the user user0 to the group Group1 | 
@skjnldsv Do you think these could be reenabled now? Should probably be a different PR.
| 
 Highly doubt it, we're late by one major on selenium. | 
| Needs a rebase | 
Signed-off-by: Gary Kim <gary@garykim.dev>
a83e1f2    to
    5ae3860      
    Compare
  
    | @rullzer Done | 
Closes #18211
Fix removing groups that have a slash in the name such as
/test.I will backport manually once this is merged.