-
-
Couldn't load subscription status.
- Fork 4.6k
Only run integration tests when PHP was modified #16879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only run integration tests when PHP was modified #16879
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
|
Nice idea!! |
|
Integration tests are not relevant for pull requests like #16798? |
no, they're only testing apis :) |
No, integration tests make API calls only. No JS or browser involved. |
Thank you for explaining 👍 |
|
Mh, do I understand correctly, you want to run them only after a PR was merged? |
No, only if the commits include changes on a php file, an integration test or if it's a merge commit! :) |
|
What @skjnldsv said. We do it like that since some weeks in Talk and it helped to improve the queue timers for JS/CSS only changes quite a lot. Now server is the biggest time drain and at least for pushes to JS/CSS only changes it is unnecessary to repeatedly check the integration tests. Merge commits always run the integration tests on master/stableX afterwards |
|
Could probably do the same on all the DB runs right? |
The time gain there is not a lot, but yeah. Anyway lets start like this and see how it works out. |
|
We could replace the default clone step with a custom one (https://docs.drone.io/user-guide/pipeline/cloning/#custom-logic) like for the submodules and run the check there. Benefits:
|
|
/backport to stable16 |
|
backport to stable16 in #16909 |
Integration tests are now only run when:
build/integrationwas modified