Fix scrolling after switching to grid view

[inthreedee]

Fixes #16510

Switching to grid view from list view can break the scrolling and fail to load more files. In this situation, only the files that were visible in list view are initially displayed. In a large enough browser window and/or high enough screen resolution, this could mean a lot of empty space on the page, and scrolling to load the rest of the files is broken/not possible.

To solve this, I used the same solution that currently exists when toggling hidden files:

server/apps/files/js/filelist.js

Lines 272 to 275 in e51c269

	if (!showHidden) {
	// hiding files could make the page too small, need to try rendering next page
	self._onScroll();
	}

One question though: I'm stepping into the Nextcloud code for the first time. When searching the code, I found the same onGridViewChange function here, but I have no idea what this file does. It doesn't seem to implement the on_scroll function so the fix can't be applied here anyway. So I assume no changes are needed here?

server/core/src/OC/dialogs.js

Line 922 in 265a284

_onGridviewChange: function () {

[juliusknorr]

One question though: I'm stepping into the Nextcloud code for the first time. When searching the code, I found the same onGridViewChange function here, but I have no idea what this file does. It doesn't seem to implement the on_scroll function so the fix can't be applied here anyway. So I assume no changes are needed here?

The file (or that part of it) is related to the file picker dialog which also has a grid view toggle but that one doesn't seem to have the issue as the file list is always fully loaded.

[inthreedee]

@juliushaertl I see that now, thank you very much for the explanation.

[welcome]

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Most developers hang out on IRC. So join #nextcloud-dev on Freenode for a chat!

[inthreedee]

/backport to stable16

[backportbot-nextcloud]

backport to stable16 in #17342