Selecting files inside search results produces wrong download link

[js94x]

regarding Issues #1274 and #2075

The method isAllSelected() in filelist.js returns true and in consequence a download link for the whole folder is built:
https://test-nc.example.org/index.php/apps/files/ajax/download.php?dir=/Pics/Wallpaper&files=Parrot&downloadStartSecret=xxxxxxxxx

Selecting files outside search results produces a correct download link:
https://test-nc.example.org/index.php/apps/files/ajax/download.php?dir=/Pics/Wallpaper/Parrot&files=["blade.jpg","blocks.jpg"]&downloadStartSecret=xxxxxxxxx
(both link are not URL-encoded due to better representing)

Removing the if-condition enables download from the search results via "select all" checkbox.
As a side effect, the list of files now is also transferred via GET parameter when explicitly downloading a entire directory. Mayby someone should look at it again.

Signed-off-by: js94x jan@js94x.de

[blizzz]

Thanks for you contribution @js94x! It seems this changes makes jsunit test fail. Mind having another look?

[js94x]

@blizzz Yes, I noticed but I wasn´t sure how to proceed. I'm not the jsunit specialist either. 😁

The failing test is there:

server/apps/files/tests/js/filelistSpec.js

Line 2252 in 37782b1

it('Downloads parent folder when all selected in subfolder', function() {

Maybe someone can give a hint?

[blizzz]

@js94x does this help? https://docs.nextcloud.com/server/14/developer_manual/core/unit-testing.html#javascript-unit-testing-for-core

[ChristophWurst]

@js94x any updates?

I see there are failures with jsunit and a new todo in the source code. We'll close this should it not receive any more updates.

[js94x]

@ChristophWurst
Sorry I didn't have had time yet. At first I have to deal a little bit with the subject of unit testing.
You can close the PR first.

I currently roll out the fix at the affected nextcloud instance after every update.

[ChristophWurst]

Okay, thanks for the update.

I'll close this now. Please send us the patch when it's ready to be integrated :)