Merge pull request #51613 from nextcloud/backport/50542/stable29

[stable29] fix(files_sharing): skip expiration notify for invalid share record

Author: provokateurin

apps/files_sharing/lib/Command/ExiprationNotification.php

@@ -26,6 +26,7 @@
  */
 namespace OCA\Files_Sharing\Command;
 
+use OCA\Files_Sharing\OrphanHelper;
 use OCP\AppFramework\Utility\ITimeFactory;
 use OCP\IDBConnection;
 use OCP\Notification\IManager as NotificationManager;
@@ -48,7 +49,9 @@ class ExiprationNotification extends Command {
 	public function __construct(ITimeFactory $time,
 		NotificationManager $notificationManager,
 		IDBConnection $connection,
-		ShareManager $shareManager) {
+		ShareManager $shareManager,
+		private OrphanHelper $orphanHelper,
+	) {
 		parent::__construct();
 
 		$this->notificationManager = $notificationManager;
@@ -80,7 +83,8 @@ public function execute(InputInterface $input, OutputInterface $output): int {
 		foreach ($shares as $share) {
 			if ($share->getExpirationDate() === null
 				|| $share->getExpirationDate()->getTimestamp() < $minTime->getTimestamp()
-				|| $share->getExpirationDate()->getTimestamp() > $maxTime->getTimestamp()) {
+				|| $share->getExpirationDate()->getTimestamp() > $maxTime->getTimestamp()
+				|| !$this->orphanHelper->isShareValid($share->getSharedBy(), $share->getNodeId())) {
 				continue;
 			}