Merge pull request #51740 from nextcloud/backport/51737/stable29

[stable29] fix(files_reminders): Fix reminder actions being displayed on invalid nodes

Author: Pytal

apps/files_reminders/src/actions/setReminderCustomAction.ts

@@ -19,7 +19,10 @@
  * along with this program. If not, see <http://www.gnu.org/licenses/>.
  *
  */
-import { FileAction, Node } from '@nextcloud/files'
+
+import type { Node, View } from '@nextcloud/files'
+
+import { FileAction } from '@nextcloud/files'
 import { translate as t } from '@nextcloud/l10n'
 import CalendarClockSvg from '@mdi/svg/svg/calendar-clock.svg?raw'
 
@@ -32,7 +35,19 @@ export const action = new FileAction({
 	title: () => t('files_reminders', 'Set reminder at custom date & time'),
 	iconSvgInline: () => CalendarClockSvg,
 
-	enabled: () => true,
+	enabled: (nodes: Node[], view: View) => {
+		if (view.id === 'trashbin') {
+			return false
+		}
+		// Only allow on a single node
+		if (nodes.length !== 1) {
+			return false
+		}
+		const node = nodes.at(0)!
+		const dueDate = node.attributes['reminder-due-date']
+		return dueDate !== undefined
+	},
+
 	parent: SET_REMINDER_MENU_ID,
 
 	async exec(file: Node) {

apps/files_reminders/src/actions/setReminderMenuAction.ts

@@ -19,6 +19,9 @@
  * along with this program. If not, see <http://www.gnu.org/licenses/>.
  *
  */
+
+import type { Node, View } from '@nextcloud/files'
+
 import { FileAction } from '@nextcloud/files'
 import { translate as t } from '@nextcloud/l10n'
 import AlarmSvg from '@mdi/svg/svg/alarm.svg?raw'
@@ -30,7 +33,18 @@ export const action = new FileAction({
 	displayName: () => t('files_reminders', 'Set reminder'),
 	iconSvgInline: () => AlarmSvg,
 
-	enabled: () => true,
+	enabled: (nodes: Node[], view: View) => {
+		if (view.id === 'trashbin') {
+			return false
+		}
+		// Only allow on a single node
+		if (nodes.length !== 1) {
+			return false
+		}
+		const node = nodes.at(0)!
+		const dueDate = node.attributes['reminder-due-date']
+		return dueDate !== undefined
+	},
 
 	async exec() {
 		return null

apps/files_reminders/src/actions/setReminderSuggestionActions.ts

@@ -21,7 +21,7 @@
  */
 
 import Vue from 'vue'
-import type { Node } from '@nextcloud/files'
+import type { Node, View } from '@nextcloud/files'
 
 import { FileAction } from '@nextcloud/files'
 import { emit } from '@nextcloud/event-bus'
@@ -91,7 +91,19 @@ const generateFileAction = (option: ReminderOption): FileAction|null => {
 		// Empty svg to hide the icon
 		iconSvgInline: () => '<svg></svg>',
 
-		enabled: () => Boolean(getDateTime(option.dateTimePreset)),
+		enabled: (nodes: Node[], view: View) => {
+			if (view.id === 'trashbin') {
+				return false
+			}
+			// Only allow on a single node
+			if (nodes.length !== 1) {
+				return false
+			}
+			const node = nodes.at(0)!
+			const dueDate = node.attributes['reminder-due-date']
+			return dueDate !== undefined && Boolean(getDateTime(option.dateTimePreset))
+		},
+
 		parent: SET_REMINDER_MENU_ID,
 
 		async exec(node: Node) {