[stable29] fix(files_sharing): skip expiration notify for invalid share record #51613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot
bot
requested review from
juliusknorr,
luka-nextcloud,
nickvergessen and
provokateurin
luka-nextcloud
force-pushed
the
backport/50542/stable29
branch
2 times, most recently
from
29752bf to
b70605f
Compare
luka-nextcloud
approved these changes
Mar 21, 2025
provokateurin
approved these changes
Mar 21, 2025
AndyScherzinger
force-pushed
the
backport/50542/stable29
branch
3 times, most recently
from
20dc3d5 to
a5b26ea
Compare
juliusknorr
approved these changes
Mar 25, 2025
luka-nextcloud
force-pushed
the
backport/50542/stable29
branch
2 times, most recently
from
4bd7738 to
a5070ed
Compare
|
|
Signed-off-by: Luka Trovic <luka@nextcloud.com>
luka-nextcloud
force-pushed
the
backport/50542/stable29
branch
from
a5070ed to
8068ee8
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if ($share->getExpirationDate() === null | ||
| || $share->getExpirationDate()->getTimestamp() < $minTime->getTimestamp() | ||
| || $share->getExpirationDate()->getTimestamp() > $maxTime->getTimestamp()) { | ||
| || $share->getExpirationDate()->getTimestamp() > $maxTime->getTimestamp() |
Check notice
Code scanning / Psalm
PossiblyNullReference Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #50542
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.