Skip to content

Commit

Permalink
Merge pull request #44575 from nextcloud/fix/no-autocomplete-sharing
Browse files Browse the repository at this point in the history
fix(files_sharing): Disable autocomplete for share label and password
  • Loading branch information
susnux authored Apr 2, 2024
2 parents e05ed23 + 677a642 commit 6c3a1a3
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 10 deletions.
7 changes: 4 additions & 3 deletions apps/files_sharing/src/views/SharingDetailsTab.vue
Original file line number Diff line number Diff line change
Expand Up @@ -101,14 +101,15 @@
role="region">
<section>
<NcInputField v-if="isPublicShare"
:value.sync="share.label"
type="text"

This comment has been minimized.

Copy link
@Flow-Gee

Flow-Gee Apr 3, 2024

Did you remove type="text" on purpose?

:label="t('files_sharing', 'Share label')" />
autocomplete="off"
:label="t('files_sharing', 'Share label')"
:value.sync="share.label" />
<template v-if="isPublicShare">
<NcCheckboxRadioSwitch :checked.sync="isPasswordProtected" :disabled="isPasswordEnforced">
{{ t('files_sharing', 'Set password') }}
</NcCheckboxRadioSwitch>
<NcPasswordField v-if="isPasswordProtected"
autocomplete="new-password"
:value="hasUnsavedPassword ? share.newPassword : ''"
:error="passwordError"
:helper-text="errorPasswordLabel"
Expand Down
1 change: 0 additions & 1 deletion dist/2641-2641.js.map

This file was deleted.

6 changes: 3 additions & 3 deletions dist/2641-2641.js → dist/4997-4997.js

Large diffs are not rendered by default.

File renamed without changes.
1 change: 1 addition & 0 deletions dist/4997-4997.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/files_sharing-files_sharing_tab.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/files_sharing-files_sharing_tab.js.map

Large diffs are not rendered by default.

0 comments on commit 6c3a1a3

Please sign in to comment.