Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files_sharing): Disable autocomplete for share label and password #44575

Merged
merged 2 commits into from
Apr 2, 2024
Merged

fix(files_sharing): Disable autocomplete for share label and password #44575

merged 2 commits into from
Apr 2, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Mar 29, 2024

Summary

Prevent browsers - as good as possible - from filling in user credentials as share label and password.

Checklist

@susnux susnux added this to the Nextcloud 30 milestone Mar 29, 2024
@susnux
Copy link
Contributor Author

susnux commented Mar 29, 2024

/backport to stable29

@susnux
Copy link
Contributor Author

susnux commented Mar 29, 2024

/backport to stable28

@susnux susnux mentioned this pull request Mar 29, 2024
Closed
8 tasks
@susnux susnux force-pushed the fix/no-autocomplete-sharing branch from 01196e5 to 9cb63bd Compare March 29, 2024 23:59
@susnux
Copy link
Contributor Author

susnux commented Mar 29, 2024

/compile

@susnux susnux enabled auto-merge March 30, 2024 00:00
@susnux
fix(files_sharing): Disable autocomplete for share label and password
85108cf 
Prevent browsers - as good as possible - from filling in user credentials as share label and password.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: Compile assets
677a642 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/no-autocomplete-sharing branch from 2fd8202 to 677a642 Compare April 2, 2024 10:36
@susnux susnux merged commit 6c3a1a3 into master Apr 2, 2024
104 checks passed
@susnux susnux deleted the fix/no-autocomplete-sharing branch April 2, 2024 12:06
This was referenced Apr 2, 2024
Merged
Merged
@susnux susnux mentioned this pull request Apr 12, 2024
Closed
8 tasks
@github-actions GitHub Actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fenn-CS Fenn-CS Fenn-CS approved these changes

@emoral435 emoral435 emoral435 approved these changes

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: sharing feedback-requested
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.

[Bug]: Autofill “Share label” and “Set password” fields when editing a shared link
3 participants
@susnux @Fenn-CS @emoral435