fix focus in filepicker

[hamza221]

A really hacky way to fix focus in the file picker focus

Repro:

1. open photos settings
2. open file picker to change the default photos directory
3. try navigating with keyboard or creating a new folder

PS: Manually focusing and changing tabindex didn't work

[ChristophWurst]

could you elaborate on the solution? you're watching the document body and move the dialogs element into the modal, right?

would it also be possible to register the dialogs element as additional focus trap elements for the modal?

[hamza221]

changing to WIP until nextcloud-libraries/nextcloud-vue#3947 gets merged

[artonge]

Works, but the behavior is still weird, as you can focus items from the setting modal behind the file picker. Shouldn't the file picker still the focus? If so, shouldn't the solution be in nc/dialogs?

[artonge]

/rebase

[artonge]

Rebasing to have green CI

[ChristophWurst]

If so, shouldn't the solution be in nc/dialogs?

yeah nextcloud-libraries/nextcloud-dialogs#1 🥲 Right now the picker is built with jquery UI.

[artonge]

/compile amend /

[artonge]

@hamza221 can you squash your fixups ?

[ChristophWurst]

squashed

[ChristophWurst]

/backport to stable26

[ChristophWurst]

/backport to stable25

[backportbot-nextcloud]

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin/stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

[ChristophWurst]

@artonge is it safe to backport the change to 25 considering the nc/vue bump in here?

[artonge]

Should be safe for 25 yes, can you try and test?

[ChristophWurst]

No luck so far #1741 (comment)

[artonge]

Is this still needed after nextcloud/server#37780 ?

[hamza221]

Is this still needed after nextcloud/server#37780 ?

It's not, I think we can revert this

[artonge]

Is this still needed after nextcloud/server#37780 ?

It's not, I think we can revert this

Can you handle it?